Skip to content

Conversation

@InsanityAutomation
Copy link
Contributor

Add pause state handling to ExtUI so that devices can monitor changes in state and handle messaging directly, as well as catch scenarios where the user may have browsed away from a screen to recall popups.

Add fast resume, reducing button pushes to continue.

@thisiskeithb
Copy link
Member

thisiskeithb commented Aug 28, 2021

..Sort of resolves #9195 as well.

@InsanityAutomation
Copy link
Contributor Author

It is a start on it, following that functionality in M600. Just took a glance at that and it seems pretty easy to do using things we have in place now.

@thinkyhead
Copy link
Member

@InsanityAutomation — Please delete your dead branches!

2 similar comments
@thinkyhead
Copy link
Member

@InsanityAutomation — Please delete your dead branches!

@thinkyhead
Copy link
Member

@InsanityAutomation — Please delete your dead branches!

@thinkyhead thinkyhead force-pushed the ExtUIPauseStateHandling branch from fcc8dd4 to cb62b94 Compare September 1, 2021 09:54
@InsanityAutomation
Copy link
Contributor Author

@InsanityAutomation — Please delete your dead branches!

I actually don't have that many dead ones, I think there's only one or two to remove! With 70 machines, most of them different models you end up with a lot of different branches...

@thinkyhead
Copy link
Member

thinkyhead commented Sep 4, 2021

I think there's only one or two to remove

The problem is not purely the number of branches, but that there are a lot of dead or dangling references that are no longer in the upstream repo or our working copies, so if you cannot delete them then you have a couple of options to make things friendlier for us:

  • You could rebase them on some tagged version of Marlin, either in the 2.0.x branch or the bugfix-2.0.x branch, and then push the rebased branches. This way git fetch will only need to pull down the references that it doesn't yet have.

  • Another perfectly good option is to create a new repository separate from the one you use to submit upstream changes, reset it to be a clone of upstream Marlin and/or do a git remote add of MarlinFirmware/Marlin for convenience, and move your 70 machine-specific branches there. Then you can delete them from the repository that you use for submitting PRs.

@thinkyhead thinkyhead force-pushed the ExtUIPauseStateHandling branch from b344a4f to 6af0cb6 Compare September 4, 2021 07:59
@thinkyhead thinkyhead force-pushed the ExtUIPauseStateHandling branch from 6af0cb6 to f10bc1e Compare September 4, 2021 08:17
@thinkyhead thinkyhead force-pushed the ExtUIPauseStateHandling branch from f10bc1e to 0863c78 Compare September 4, 2021 08:35
@thinkyhead thinkyhead force-pushed the bugfix-2.0.x branch 2 times, most recently from f4c2f00 to 02ae11e Compare September 16, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants